Align built-in client windows with the reviewed UI style guide
Systematically inventory and refine every built-in PRK.Client window/layout family against PRK.Client/StyleGuide/index.html and DESIGN.md. Start with shared shell, renderer and Core recipes; then inspect each package and native layout rather than applying a blind XML sweep. Preserve commands, binding identities, permissions, placement persistence, combat restrictions and game semantics. Apply thin-outline inputs, correctly sliced sliders, complete scrollbars, internal-tab frames/seams, NCU cover cropping, shared spacing/type/control heights, compact table conventions and slot layering. Use real local install assets and existing render/acceptance facilities, not HTML as proof of native parity. Keep explicit evidence and limitations for source review versus screenshots; no gameplay/wire changes or copied stock executable code. Acceptance: each built-in window family reviewed and discrepancies addressed or explicitly documented as intentional; relevant builds, renderer tests and Lua/UI acceptance checks pass; actual rendered comparisons made for shared primitives and representative windows at normal/minimum sizes and UI scales. Implementation branch: refactor/client-ui-style-cleanup, rebased onto origin/develop3d7b64d2d after the merged style guide and inventory/bank/shop search changes. The reviewed cleanup commit is now6adc433f5 (previously646caa65c); branch is pushed to origin/refactor/client-ui-style-cleanup at6adc433f5. The second layout batch is committed as007cd8a88 and pushed with the first cleanup batch; working tree clean. Only the cleanup commit was replayed; merged documentation commits were not duplicated. Inventory's list minimum320px and column fitting are retained together with upstream's dynamic search-height reservation. Shop search markup, wiring, highlighting and added height remain intact. The19-file uncommitted second batch was stashed/restored and its binary diff verified byte-identical; backup patch is under .dev-data/ui-style-cleanup/rebase. Rebase validation: warning-as-error client build (NU1903 exempt),102 inventory/bank/search/trade tests with no skips, and the complete native Lua/API/scripting/UI AOT runner pass. Continue remaining families and restyle the new search controls as a separate follow-up, preserving their height reservations and bindings. Native baseline: container build succeeded, but its image lacks Vulkan; running the built assembly on the host AMD Vulkan driver passed30 selected checks with1 install-data skip. Baseline screenshots preserved under .dev-data/ui-style-cleanup/before. Three renderer regressions demonstrated red then green for transparent field interiors, fixed-width sliced slider caps with a separate hit row, and center-cropped cover icons. Source review confirms native scrollbars already have cropped thumbs and end arrows; preserve them. Verified first implementation batch: shared 13px/white body typography and legible disabled opacity; transparent neutral/focused input/select outlines; compound border_style=input plus draw_border=false to prevent nested frames; sliced slider tracks (with the authored18px Agg/Def exception preserved); NCU/pet cover cropping; foreground tab-strip paint/input ordering for Wear; explicit Lua table alignment and inventory column fitting/minimum width. Perks tabs are moved into the shell header by Lua, so its extra inner frame was rejected/removed after tracing composition and checking the native capture. Options now uses13px labels,28px controls, consistent spacing and a fixed right-aligned range readout lane; a real100% readout overflow reproduced at100/125/150% before the flexible-slider fix. Options screenshot fixture now measures text with the same scaled native context as rendering. Prompts and Friends lose duplicate field wrappers; chat's compound editor has one outline. User-prioritized credit fix: player-trade editable/read-only amounts and NPC hand-over credit editor have a single frame, including focused/unfocused regression coverage. Native trade and NPC screenshots inspected. Final batch validation: warning-as-error renderer/client test builds succeed (NU1903 remains exempt);286 GUI tests pass;1715 selected client UI tests pass with25 explicit environment-dependent skips; native Lua release/sanitizer tests, API generator self-tests and scripting/UI Native AOT acceptance all pass. XML/Lua syntax and git diff checks pass. Native captures are under .dev-data/ui-style-cleanup/after; Options Display/Graphics/Interface captures inspected at100/125/150%. Second batch verified and committed: intrinsic-height/stacked confirmation footers, native/Skills/team invitation action styles, map controls/minimum bounds, info navigation, chat configuration and team search. Long-dialog geometry red/green covers six width/scale cases. Checkbox artwork now targets an explicitly interactive channel row; its input test reveals the scrolled target and uses ScreenPosition, proves an inactive-row control does not toggle, then verifies the declared hit target toggles once for only the selected chat window. Native minimum-size Chat Config/Team Search and ordinary/three-action dialog captures inspected. Team Search column-fit regression fails with fitting disabled in the test artifact and passes when restored. Final PR validation: warning-as-error client/renderer builds (NU1903 exempt),1883 relevant client tests pass with22 explicit environment-dependent skips,286 GUI tests pass, complete native Lua release/sanitizer/API/scripting/UI AOT runner passes. Changed XML/Lua and git diff checks pass. Test captures/logs under .dev-data/ui-style-cleanup/pr. The GUI-only install helper now accepts PRK_GUIROOT, enabling previously skipped GUI-asset cases without a full RDB install. This validates the selected patch, not the outstanding per-window migration. The overall per-window cleanup is NOT complete. Next: continue native login/character creation/map/info/debug/dialog layouts, then remaining social/progression/commerce/HUD families, including remaining22/24px ordinary controls, arbitrary panel colors/frames, other table schemas and full-column visibility. Do not equate broad functional acceptance with visual review of each window. Some families have only been source-opened/scanned; only the explicitly listed native captures and controls are visually checked. Bright-world compositing and minimum-size/scale coverage across every window remain outstanding. Keep the family checklists open until those reviews are finished. PR #2984: https://git.project-rk.com/prk/engines/pulls/2984 Head: refactor/client-ui-style-cleanup; base: develop. Commits:6adc433f5 and007cd8a88.
Checklist
1 of 6 complete- Standardize and verify shared field/select outlines, slider slicing, NCU cropping, tab paint/input order, default typography and Lua table alignment; preserve existing complete scrollbar rendering.
- Review native layouts: login/creation, options, prompts/confirmations, maps/info/tooltips, developer/debug/loading overlays; align styling or record intentional exceptions.
- Review item/HUD families: inventory/bags/bank/loot, actions, nanos/NCU, Wear, trade/tradeskills, hotbars, vitals/targets/timers/control center.
- Review progression and commerce families: skills/stats/perks, missions/terminal/reward picker/grid node, market and compact/inset tables.
- Review social families: chat/frame/config/menu, friends, team/invite/search, pets, NPC conversation/trade.
- Run relevant renderer/client builds, regression tests and Lua UI acceptance; finish visual checks and preserve explicit remaining limitations before completion.
- Area
- Project Rubi-Ka
- Project
- engines
- Kind
- Chore
- Task ID
tsk_txdyzjgxxp- Updated